Add more CC warning option to debug mode

diff --git a/configure.ac b/configure.ac
index eae42958315d8f101413ca820f2e806228075d2c..3789cf0ebbe661c2f3cda0726b2f77a1a855d1a0 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -172,6 +172,7 @@ dnl Check extra warning flags except
 dnl    -Wconversion            -> we need it
 dnl    -Wunreachable-code      -> fails with ntoh*
 dnl    -Wpointer-arith         -> limbnl uses it
+dnl    -Wsign-conversion       -> libmnl
 if test "x$enable_debug" = "xyes"
 then
 AX_CFLAGS_GCC_OPTION(-Waggregate-return)
@@ -182,22 +183,28 @@ AX_CFLAGS_GCC_OPTION(-Werror)
 AX_CFLAGS_GCC_OPTION(-Wextra)
 AX_CFLAGS_GCC_OPTION(-Wfloat-equal)
 AX_CFLAGS_GCC_OPTION(-Wformat=2)
+AX_CFLAGS_GCC_OPTION(-Wjump-misses-init)
 AX_CFLAGS_GCC_OPTION(-Winit-self)
 AX_CFLAGS_GCC_OPTION(-Winline)
+AX_CFLAGS_GCC_OPTION(-Wlogical-op)
 AX_CFLAGS_GCC_OPTION(-Wmissing-declarations)
 AX_CFLAGS_GCC_OPTION(-Wmissing-format-attribute)
 AX_CFLAGS_GCC_OPTION(-Wmissing-prototypes)
 AX_CFLAGS_GCC_OPTION(-Wnested-externs)
 AX_CFLAGS_GCC_OPTION(-Wno-missing-field-initializers)
+AX_CFLAGS_GCC_OPTION(-Wold-style-definition)
 AX_CFLAGS_GCC_OPTION(-Woverlength-strings)
 AX_CFLAGS_GCC_OPTION(-Wpacked)
 AX_CFLAGS_GCC_OPTION(-Wredundant-decls)
+AX_CFLAGS_GCC_OPTION(-Wrwrite-strings)
 AX_CFLAGS_GCC_OPTION(-Wshadow)
 AX_CFLAGS_GCC_OPTION(-Wsign-compare)
 AX_CFLAGS_GCC_OPTION(-Wstrict-prototypes)
 AX_CFLAGS_GCC_OPTION(-Wswitch-default)
 AX_CFLAGS_GCC_OPTION(-Wundef)
+AX_CFLAGS_GCC_OPTION(-Wuninitialized)
 AX_CFLAGS_GCC_OPTION(-Wunused)
+AX_CFLAGS_GCC_OPTION(-Wvla)
 AX_CFLAGS_GCC_OPTION(-Wwrite-strings)
 fi
 dnl Checks for library functions.

diff --git a/include/libipset/data.h b/include/libipset/data.h
index 5d801852126d896296f3f2f6e94ca95b65db5392..b7e7747f4c6f13ad309d8c637f9f9f74b033e778 100644 (file)
--- a/include/libipset/data.h
+++ b/include/libipset/data.h
@@ -65,8 +65,8 @@ enum ipset_opt {
        IPSET_OPT_MAX,
 };
 
-#define IPSET_FLAG(opt)                (1LL << (opt))
-#define IPSET_FLAGS_ALL                (~0LL)
+#define IPSET_FLAG(opt)                (1ULL << (opt))
+#define IPSET_FLAGS_ALL                (~0ULL)
 
 #define IPSET_CREATE_FLAGS             \
        (IPSET_FLAG(IPSET_OPT_FAMILY)   \

diff --git a/lib/ipset_bitmap_ip.c b/lib/ipset_bitmap_ip.c
index 8290803ae6b05c183da2a78b163574a8606cbc00..fae3d81e28568d2fa812df178e07f58487d6c457 100644 (file)
--- a/lib/ipset_bitmap_ip.c
+++ b/lib/ipset_bitmap_ip.c
@@ -96,6 +96,7 @@ static struct ipset_type ipset_bitmap_ip0 = {
        .usage = bitmap_ip_usage,
 };
 
+void _init(void);
 void _init(void)
 {
        ipset_type_add(&ipset_bitmap_ip0);

diff --git a/lib/ipset_bitmap_ipmac.c b/lib/ipset_bitmap_ipmac.c
index 6f51293685ffeab4d2023c6160b0d2f830327b0c..9f591cd289df736719cec2bc7a304aa98db0174a 100644 (file)
--- a/lib/ipset_bitmap_ipmac.c
+++ b/lib/ipset_bitmap_ipmac.c
@@ -99,6 +99,7 @@ static struct ipset_type ipset_bitmap_ipmac0 = {
        .usage = bitmap_ipmac_usage,
 };
 
+void _init(void);
 void _init(void)
 {
        ipset_type_add(&ipset_bitmap_ipmac0);

diff --git a/lib/ipset_bitmap_port.c b/lib/ipset_bitmap_port.c
index de02e5057ab8ff834c06d78489fbcd7e0c306d24..7b1f83925c9c0bac545fd5aa42daec16f98b9280 100644 (file)
--- a/lib/ipset_bitmap_port.c
+++ b/lib/ipset_bitmap_port.c
@@ -86,6 +86,7 @@ static struct ipset_type ipset_bitmap_port0 = {
        .usage = bitmap_port_usage,
 };
 
+void _init(void);
 void _init(void)
 {
        ipset_type_add(&ipset_bitmap_port0);

diff --git a/lib/ipset_hash_ip.c b/lib/ipset_hash_ip.c
index 40f684f269df4020a5c2ff9a733af093582b38f0..6a03d38bc2ddb52e9aafbbc8181a26112f9d3e99 100644 (file)
--- a/lib/ipset_hash_ip.c
+++ b/lib/ipset_hash_ip.c
@@ -118,6 +118,7 @@ static struct ipset_type ipset_hash_ip0 = {
        .usage = hash_ip_usage,
 };
 
+void _init(void);
 void _init(void)
 {
        ipset_type_add(&ipset_hash_ip0);

diff --git a/lib/ipset_hash_ipport.c b/lib/ipset_hash_ipport.c
index c9c3b600f4d2bb7f091ce82d056b0072988128c4..5e80084d3c7433e7ce09a7eb4f6c86ab227aa31e 100644 (file)
--- a/lib/ipset_hash_ipport.c
+++ b/lib/ipset_hash_ipport.c
@@ -143,6 +143,7 @@ static struct ipset_type ipset_hash_ipport1 = {
        .usagefn = ipset_port_usage,
 };
 
+void _init(void);
 void _init(void)
 {
        ipset_type_add(&ipset_hash_ipport1);

diff --git a/lib/ipset_hash_ipportip.c b/lib/ipset_hash_ipportip.c
index ac6182bc3006fc2764fce3e1b7a4f0fc18a46c29..f99d85faf512e37d11dd1ce976deabc76a078a39 100644 (file)
--- a/lib/ipset_hash_ipportip.c
+++ b/lib/ipset_hash_ipportip.c
@@ -154,6 +154,7 @@ static struct ipset_type ipset_hash_ipportip1 = {
        .usagefn = ipset_port_usage,
 };
 
+void _init(void);
 void _init(void)
 {
        ipset_type_add(&ipset_hash_ipportip1);

diff --git a/lib/ipset_hash_ipportnet.c b/lib/ipset_hash_ipportnet.c
index 6750208402f8c5dd03f1a098b22d085f524f0624..5a2d97c45984470a9c5ff45724392d463b2ee196 100644 (file)
--- a/lib/ipset_hash_ipportnet.c
+++ b/lib/ipset_hash_ipportnet.c
@@ -357,6 +357,7 @@ static struct ipset_type ipset_hash_ipportnet3 = {
        .usagefn = ipset_port_usage,
 };
 
+void _init(void);
 void _init(void)
 {
        ipset_type_add(&ipset_hash_ipportnet1);

diff --git a/lib/ipset_hash_net.c b/lib/ipset_hash_net.c
index bab33e22c4a3d7d05c99a339b939aa4c480abd78..789bcd2ab087661a72aa251d7b98ee55680443e9 100644 (file)
--- a/lib/ipset_hash_net.c
+++ b/lib/ipset_hash_net.c
@@ -229,6 +229,7 @@ static struct ipset_type ipset_hash_net2 = {
        .usage = hash_net2_usage,
 };
 
+void _init(void);
 void _init(void)
 {
        ipset_type_add(&ipset_hash_net0);

diff --git a/lib/ipset_hash_netiface.c b/lib/ipset_hash_netiface.c
index e60acbfc6f28edc237ca2c379d9cf4ce8ff2347b..bc6aa3ddd629a78096b8cd24af2105f24e2c3b19 100644 (file)
--- a/lib/ipset_hash_netiface.c
+++ b/lib/ipset_hash_netiface.c
@@ -200,6 +200,7 @@ static struct ipset_type ipset_hash_netiface1 = {
        .usage = hash_netiface1_usage,
 };
 
+void _init(void);
 void _init(void)
 {
        ipset_type_add(&ipset_hash_netiface0);

diff --git a/lib/ipset_hash_netport.c b/lib/ipset_hash_netport.c
index 285f06c381915104e97b55cc1124bd81307a49e8..e638756bb4bda780d4f672022dac85b4004f5fe9 100644 (file)
--- a/lib/ipset_hash_netport.c
+++ b/lib/ipset_hash_netport.c
@@ -287,6 +287,7 @@ static struct ipset_type ipset_hash_netport3 = {
        .usagefn = ipset_port_usage,
 };
 
+void _init(void);
 void _init(void)
 {
        ipset_type_add(&ipset_hash_netport1);

diff --git a/lib/ipset_list_set.c b/lib/ipset_list_set.c
index dc0bf5354f778a7b461081a21815d4e2764a8b75..69a1379c5d4fef85e72d56e6d81d9be6e358bc38 100644 (file)
--- a/lib/ipset_list_set.c
+++ b/lib/ipset_list_set.c
@@ -90,6 +90,7 @@ static struct ipset_type ipset_list_set0 = {
        .usage = list_set_usage,
 };
 
+void _init(void);
 void _init(void)
 {
        ipset_type_add(&ipset_list_set0);