[#1578] also fixed report values

diff --git a/src/hooks/dhcp/high_availability/communication_state.cc b/src/hooks/dhcp/high_availability/communication_state.cc
index 8153e320452a8a33a59f96b3930943516e4465dd..d1fe6e1247422498e6f692b5c549b4bcdd3c8754 100644 (file)
--- a/src/hooks/dhcp/high_availability/communication_state.cc
+++ b/src/hooks/dhcp/high_availability/communication_state.cc
@@ -341,9 +341,9 @@ CommunicationState::getReport() const {
     report->set("unacked-clients", Element::create(static_cast<long long>(getUnackedClientsCount())));
 
     long long unacked_clients_left = 0;
-    if (isCommunicationInterrupted() && (config_->getMaxUnackedClients() > getUnackedClientsCount())) {
+    if (isCommunicationInterrupted() && (config_->getMaxUnackedClients() >= getUnackedClientsCount())) {
         unacked_clients_left = static_cast<long long>(config_->getMaxUnackedClients() -
-                                                      getUnackedClientsCount());
+                                                      getUnackedClientsCount() + 1);
     }
     report->set("unacked-clients-left", Element::create(unacked_clients_left));
     report->set("analyzed-packets", Element::create(static_cast<long long>(getAnalyzedMessagesCount())));

diff --git a/src/hooks/dhcp/high_availability/tests/communication_state_unittest.cc b/src/hooks/dhcp/high_availability/tests/communication_state_unittest.cc
index 4aba7e080d37ec0023379647e56cc24d401b4ee2..ecdd3adcc3b53183673a1e028e2f8ab1d7be952e 100644 (file)
--- a/src/hooks/dhcp/high_availability/tests/communication_state_unittest.cc
+++ b/src/hooks/dhcp/high_availability/tests/communication_state_unittest.cc
@@ -775,7 +775,7 @@ TEST_F(CommunicationStateTest, getReport) {
         "    \"communication-interrupted\": true,"
         "    \"connecting-clients\": 2,"
         "    \"unacked-clients\": 1,"
-        "    \"unacked-clients-left\": 9,"
+        "    \"unacked-clients-left\": 10,"
         "    \"analyzed-packets\": 2"
         "}";
     EXPECT_TRUE(isEquivalent(Element::fromJSON(expected), report));