]> git.ipfire.org Git - thirdparty/openvpn.git/commitdiff
polarssl: make sure to always null-terminate the cn
authorSteffan Karger <steffan@karger.me>
Thu, 5 Mar 2015 21:58:36 +0000 (22:58 +0100)
committerGert Doering <gert@greenie.muc.de>
Fri, 6 Mar 2015 18:34:33 +0000 (19:34 +0100)
Just a precaution, this could never fail in the current code since in the
one place this function is called, the cn is already zero-initialized.

Signed-off-by: Steffan Karger <steffan@karger.me>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1425592716-14243-2-git-send-email-steffan@karger.me>
URL: http://article.gmane.org/gmane.network.openvpn.devel/9511
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/ssl_verify_polarssl.c

index e21301d3090002326d5e5ffe7008dca6eda97b7f..2edf21dd3dd18c6f755e01725c28efed3b68838f 100644 (file)
@@ -115,7 +115,10 @@ backend_x509_get_username (char *cn, int cn_len,
 
   /* Found, extract CN */
   if (cn_len > name->val.len)
-    memcpy( cn, name->val.p, name->val.len );
+    {
+      memcpy( cn, name->val.p, name->val.len );
+      cn[name->val.len] = '\0';
+    }
   else
     {
       memcpy( cn, name->val.p, cn_len);