]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
printk: add CONFIG_PRINTK dependency for netconsole
authorArnd Bergmann <arnd@arndb.de>
Fri, 13 Feb 2026 07:44:00 +0000 (08:44 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 17 Feb 2026 12:04:20 +0000 (13:04 +0100)
The 'select PRINTK_EXECUTION_CTX' line now causes a harmless warning
when NETCONSOLE_DYNAMIC is enabled but PRINTK is not:

WARNING: unmet direct dependencies detected for PRINTK_EXECUTION_CTX
  Depends on [n]: PRINTK [=n]
  Selected by [y]:
  - NETCONSOLE_DYNAMIC [=y] && NETDEVICES [=y] && NET_CORE [=y] && NETCONSOLE [=y] && SYSFS [=y] && CONFIGFS_FS [=y] && (NETCONSOLE [=y]!=y [=y] || CONFIGFS_FS [=y]!=m [=m])

In that configuration, the netconsole driver is useless anyway, so
avoid this with an added dependency that prevents CONFIG_NETCONSOLE
to be enabled without CONFIG_PRINTK.

Fixes: 60325c27d3cf ("printk: Add execution context (task name/CPU) to printk_info")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260213074431.1729627-1-arnd@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/Kconfig

index 7e9becad91dfbb5a5fe362a4110630dc95af9149..17108c3592166cd98a4869e68010e4b0e8471612 100644 (file)
@@ -333,6 +333,7 @@ config MACSEC
 
 config NETCONSOLE
        tristate "Network console logging support"
+       depends on PRINTK
        help
          If you want to log kernel messages over the network, enable this.
          See <file:Documentation/networking/netconsole.rst> for details.