]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
hwmon: (tmp421) Check error when loading label from dt
authorBruno Thomsen <bruno.thomsen@gmail.com>
Tue, 11 Nov 2025 14:44:05 +0000 (15:44 +0100)
committerGuenter Roeck <linux@roeck-us.net>
Thu, 13 Nov 2025 20:23:14 +0000 (12:23 -0800)
Add error checking when loading temperature channel label defined
in device tree. Handling of error from of_property_read_string()
is inspired by lm90 driver and therefor contain same error string.

Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
Link: https://lore.kernel.org/r/20251111144406.7489-1-bruno.thomsen@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/tmp421.c

index 2e43ce8408d6c125c6ec022864d6d72adf066d89..5d6babdadf895a5eef5d3343038cdcf0c50d2db5 100644 (file)
@@ -369,7 +369,11 @@ static int tmp421_probe_child_from_dt(struct i2c_client *client,
                return -EINVAL;
        }
 
-       of_property_read_string(child, "label", &data->channel[i].label);
+       err = of_property_read_string(child, "label", &data->channel[i].label);
+       if (err == -ENODATA || err == -EILSEQ) {
+               dev_err(dev, "invalid label property in %pOFn\n", child);
+               return err;
+       }
        if (data->channel[i].label)
                data->temp_config[i] |= HWMON_T_LABEL;