]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
platform/x86/intel/pmt/discovery: fix format string warning
authorArnd Bergmann <arnd@arndb.de>
Fri, 11 Jul 2025 07:27:09 +0000 (09:27 +0200)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Fri, 11 Jul 2025 15:00:48 +0000 (18:00 +0300)
When -Wformat-security is enabled, this new code triggers it:

drivers/platform/x86/intel/pmt/discovery.c: In function 'pmt_features_discovery':
drivers/platform/x86/intel/pmt/discovery.c:505:36: error: format not a string literal and no format arguments [-Werror=format-security]
  505 |                                    pmt_feature_names[feature->id]);

Fixes: d9a078809356 ("platform/x86/intel/pmt: Add PMT Discovery driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20250711072718.2748415-1-arnd@kernel.org
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/intel/pmt/discovery.c

index 1a680a042a98e55651e44ed9934c9eb699f162b2..32713a194a550dd1a05a05fb8b563403612d18ab 100644 (file)
@@ -502,7 +502,7 @@ static int pmt_features_discovery(struct pmt_features_priv *priv,
        }
 
        ret = kobject_init_and_add(&feature->kobj, ktype, &priv->dev->kobj,
-                                  pmt_feature_names[feature->id]);
+                                  "%s", pmt_feature_names[feature->id]);
        if (ret)
                return ret;