]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuBuildCommandLine: Drop 'snapshot' argument
authorPeter Krempa <pkrempa@redhat.com>
Tue, 13 May 2025 15:12:09 +0000 (17:12 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 16 May 2025 12:48:20 +0000 (14:48 +0200)
After recent refactors that removed legacy way to revert snapshots we no
longer need to know the snapshot state during commandline build.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_command.c
src/qemu/qemu_command.h
src/qemu/qemu_process.c

index 2f687779cd772dd8350cb1145470229873c756bf..08069ffac89cc85acc3ecedc0e9964f57b9a236a 100644 (file)
@@ -10483,7 +10483,6 @@ qemuBuildCompatDeprecatedCommandLine(virCommand *cmd,
 virCommand *
 qemuBuildCommandLine(virDomainObj *vm,
                      const char *migrateURI,
-                     virDomainMomentObj *snapshot,
                      virNetDevVPortProfileOp vmop,
                      size_t *nnicindexes,
                      int **nicindexes)
@@ -10497,8 +10496,8 @@ qemuBuildCommandLine(virDomainObj *vm,
     virDomainDef *def = vm->def;
     virQEMUCaps *qemuCaps = priv->qemuCaps;
 
-    VIR_DEBUG("Building qemu commandline for def=%s(%p) migrateURI=%s snapshot=%p vmop=%d",
-              def->name, def, migrateURI, snapshot, vmop);
+    VIR_DEBUG("Building qemu commandline for def=%s(%p) migrateURI=%s vmop=%d",
+              def->name, def, migrateURI, vmop);
 
     if (qemuBuildCommandLineValidate(driver, def) < 0)
         return NULL;
index a386c34f20ee8312509bfb658c46666594a5f61e..2d43cf5506bfe1b5c9c5a22926581010668dd6a5 100644 (file)
@@ -43,7 +43,6 @@ VIR_ENUM_DECL(qemuSoundCodec);
 virCommand *
 qemuBuildCommandLine(virDomainObj *vm,
                      const char *migrateURI,
-                     virDomainMomentObj *snapshot,
                      virNetDevVPortProfileOp vmop,
                      size_t *nnicindexes,
                      int **nicindexes);
index 975358b2240a7f32a8aaccd269f7805984caa7d9..9b191ebd4f6948c8dac4352ba2695f304fe73be4 100644 (file)
@@ -8046,7 +8046,7 @@ qemuProcessLaunch(virConnectPtr conn,
 
     if (!(cmd = qemuBuildCommandLine(vm,
                                      incoming ? "defer" : NULL,
-                                     snapshot, vmop,
+                                     vmop,
                                      &nnicindexes, &nicindexes)))
         goto cleanup;
 
@@ -8712,7 +8712,6 @@ qemuProcessCreatePretendCmdBuild(virDomainObj *vm,
 {
     return qemuBuildCommandLine(vm,
                                 migrateURI,
-                                NULL,
                                 VIR_NETDEV_VPORT_PROFILE_OP_NO_OP,
                                 NULL,
                                 NULL);