]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
comedi: rti802: Add sanity checks for I/O base address
authorIan Abbott <abbotti@mev.co.uk>
Fri, 30 Jan 2026 16:48:10 +0000 (16:48 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Apr 2026 13:49:40 +0000 (15:49 +0200)
The "rti800" driver uses an admin-supplied configuration option
(`it->options[0]`) to configure the I/O port base address of a RTI-802
board.  It currently allows any base address to be configured but the
hardware only supports base addresses (configured by on-board DIP
switches) in the range 0 to 0x3FC on 4-byte boundaries.

Add a sanity check to ensure the device is not configured at an
unsupported base address.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://patch.msgid.link/20260130170416.49994-46-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/comedi/drivers/rti802.c

index d66762a22258458e2e31aed8b52c69fb5fd0460f..af990881c27af2af7fd233c91362c23df873c49c 100644 (file)
@@ -72,7 +72,8 @@ static int rti802_attach(struct comedi_device *dev, struct comedi_devconfig *it)
        int i;
        int ret;
 
-       ret = comedi_request_region(dev, it->options[0], 0x04);
+       ret = comedi_check_request_region(dev, it->options[0], 0x04,
+                                         0, 0x3ff, 4);
        if (ret)
                return ret;