]> git.ipfire.org Git - thirdparty/bootstrap.git/commitdiff
Tab: minor refactoring (#35511)
authorXhmikosR <xhmikosr@gmail.com>
Fri, 10 Dec 2021 05:51:57 +0000 (07:51 +0200)
committerGitHub <noreply@github.com>
Fri, 10 Dec 2021 05:51:57 +0000 (07:51 +0200)
* remove unneeded parentheses
* move variable

js/src/tab.js

index 4a018ca77dcbb607f2056b11af29d65a7cc001c9..f9969fb7a4eccf81439d758aaec28a8e9c468b5e 100644 (file)
@@ -5,12 +5,7 @@
  * --------------------------------------------------------------------------
  */
 
-import {
-  defineJQueryPlugin,
-  getElementFromSelector,
-  isDisabled,
-  reflow
-} from './util/index'
+import { defineJQueryPlugin, getElementFromSelector, isDisabled, reflow } from './util/index'
 import EventHandler from './dom/event-handler'
 import SelectorEngine from './dom/selector-engine'
 import BaseComponent from './base-component'
@@ -55,15 +50,15 @@ class Tab extends BaseComponent {
 
   // Public
   show() {
-    if ((this._element.parentNode &&
+    if (this._element.parentNode &&
       this._element.parentNode.nodeType === Node.ELEMENT_NODE &&
-      this._element.classList.contains(CLASS_NAME_ACTIVE))) {
+      this._element.classList.contains(CLASS_NAME_ACTIVE)) {
       return
     }
 
-    let previous
     const target = getElementFromSelector(this._element)
     const listElement = this._element.closest(SELECTOR_NAV_LIST_GROUP)
+    let previous
 
     if (listElement) {
       const itemSelector = listElement.nodeName === 'UL' || listElement.nodeName === 'OL' ? SELECTOR_ACTIVE_UL : SELECTOR_ACTIVE
@@ -75,9 +70,7 @@ class Tab extends BaseComponent {
       EventHandler.trigger(previous, EVENT_HIDE, { relatedTarget: this._element }) :
       null
 
-    const showEvent = EventHandler.trigger(this._element, EVENT_SHOW, {
-      relatedTarget: previous
-    })
+    const showEvent = EventHandler.trigger(this._element, EVENT_SHOW, { relatedTarget: previous })
 
     if (showEvent.defaultPrevented || (hideEvent !== null && hideEvent.defaultPrevented)) {
       return