]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: vchiq_arm: Register debugfs after cdev
authorStefan Wahren <wahrenst@gmx.net>
Sun, 9 Mar 2025 12:50:10 +0000 (13:50 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 20 Mar 2025 14:11:20 +0000 (07:11 -0700)
The commit 2a4d15a4ae98 ("staging: vchiq: Refactor vchiq cdev code")
moved the debugfs directory creation before vchiq character device
registration. In case the latter fails, the debugfs directory won't
be cleaned up.

Fixes: 2a4d15a4ae98 ("staging: vchiq: Refactor vchiq cdev code")
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Link: https://lore.kernel.org/r/20250309125014.37166-2-wahrenst@gmx.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

index 2db219e4786f236ce4c37afa86a12615a091c637..31bdb15fd75176ebc550c2bdce6d4120143b1ecc 100644 (file)
@@ -1386,8 +1386,6 @@ static int vchiq_probe(struct platform_device *pdev)
                return ret;
        }
 
-       vchiq_debugfs_init(&mgmt->state);
-
        dev_dbg(&pdev->dev, "arm: platform initialised - version %d (min %d)\n",
                VCHIQ_VERSION, VCHIQ_VERSION_MIN);
 
@@ -1401,6 +1399,8 @@ static int vchiq_probe(struct platform_device *pdev)
                return ret;
        }
 
+       vchiq_debugfs_init(&mgmt->state);
+
        bcm2835_audio = vchiq_device_register(&pdev->dev, "bcm2835-audio");
        bcm2835_camera = vchiq_device_register(&pdev->dev, "bcm2835-camera");