]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: dac: ds4422/ds4424 fix chip verification
authorRuslan Babayev <ruslan@babayev.com>
Sun, 5 May 2019 19:24:37 +0000 (12:24 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 9 Jun 2019 07:16:10 +0000 (09:16 +0200)
commit 60f2208699ec08ff9fdf1f97639a661a92a18f1c upstream.

The ds4424_get_value function takes channel number as it's 3rd
argument and translates it internally into I2C address using
DS4424_DAC_ADDR macro. The caller ds4424_verify_chip was passing an
already translated I2C address as its last argument.

Signed-off-by: Ruslan Babayev <ruslan@babayev.com>
Cc: xe-linux-external@cisco.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/dac/ds4424.c

index 883a475620550d4999e72b1067265aca8bb43ba7..714a97f9131997bac0bde2b7af829f449ac80bf3 100644 (file)
@@ -166,7 +166,7 @@ static int ds4424_verify_chip(struct iio_dev *indio_dev)
 {
        int ret, val;
 
-       ret = ds4424_get_value(indio_dev, &val, DS4424_DAC_ADDR(0));
+       ret = ds4424_get_value(indio_dev, &val, 0);
        if (ret < 0)
                dev_err(&indio_dev->dev,
                                "%s failed. ret: %d\n", __func__, ret);