]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commitdiff
icu: Workaround buildpaths QA check, if TMPDIR is /build/tmp
authorJörg Sommer <joerg.sommer@navimatix.de>
Sat, 28 Mar 2026 21:04:18 +0000 (22:04 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 7 Apr 2026 20:05:12 +0000 (21:05 +0100)
The file udatatst.c really contains the string /build/tmp. When building
with kas-container the build directory is /build and hence the TMPDIR
becomes /build/tmp. This triggers the QA check *buildpaths*. To work around
this, slightly modify the string in the source code.

% grep -n -C2 /build/tmp source/test/cintltst/udatatst.c
136-    char* path=(char*)malloc(sizeof(char) * (strlen(ctest_dataOutDir())
137-                                           + strlen(U_ICUDATA_NAME)
138:                                           + strlen("/build/tmp/..")+1 ) );
139-
140-    char        *icuDataFilePath = 0;

Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-support/icu/icu/mangle-build-tmp.patch [new file with mode: 0644]
meta/recipes-support/icu/icu_78.3.bb

diff --git a/meta/recipes-support/icu/icu/mangle-build-tmp.patch b/meta/recipes-support/icu/icu/mangle-build-tmp.patch
new file mode 100644 (file)
index 0000000..cf24e53
--- /dev/null
@@ -0,0 +1,32 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?J=C3=B6rg=20Sommer?= <joerg.sommer@navimatix.de>
+Date: Sat, 28 Mar 2026 20:29:53 +0100
+Subject: [PATCH] test/udatatst: Mangle /build/tmp
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+This string matches $TMPDIR (in a kas-container) which triggers the QA
+check buildpaths:
+
+ERROR: icu-78.2-r0 do_package_qa: QA Issue: File /usr/src/debug/icu/78.2/test/cintltst/udatatst.c in package icu-src contains reference to TMPDIR [buildpaths] 
+
+Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
+---
+Upstream-Status: Inappropriate [This QA check collision of Yocto specific]
+
+ test/cintltst/udatatst.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/test/cintltst/udatatst.c b/test/cintltst/udatatst.c
+index 003d7d4..7175725 100644
+--- a/test/cintltst/udatatst.c
++++ b/test/cintltst/udatatst.c
+@@ -135,7 +135,7 @@ static void TestUDataOpen(void){
+     char* path=(char*)malloc(sizeof(char) * (strlen(ctest_dataOutDir())
+                                            + strlen(U_ICUDATA_NAME)
+-                                           + strlen("/build/tmp/..")+1 ) );
++                                           + strlen("/""build/tmp/..")+1 ) );
+     char        *icuDataFilePath = 0;
+     
index 367e2641e75ff6dea66c01f12c0645a90b9b6e09..ad920f3ef4edf94f230acc18308921657f10a946 100644 (file)
@@ -111,6 +111,7 @@ SRC_URI = "${BASE_SRC_URI};name=code \
            file://0001-test-Add-support-ptest.patch \
            file://run-ptest \
            file://0001-Make-ICU-test-output-compatible-with-Automake-format.patch \
+           file://mangle-build-tmp.patch \
           "
 
 SRC_URI:append:class-target = "\