]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
[Ada] Fix detection of unused warning suppression
authorPiotr Trojanek <trojanek@adacore.com>
Mon, 25 Jul 2022 20:41:21 +0000 (22:41 +0200)
committerMarc Poulhiès <poulhies@adacore.com>
Mon, 5 Sep 2022 07:21:05 +0000 (09:21 +0200)
The comment for Warnings_Off says: "clients should generally not test
this flag directly, but instead use function Has_Warnings_Off".

Primarily a code cleanup, as this only affects minor a corner case.

gcc/ada/

* sem_ch13.adb (Validate_Unchecked_Conversions): Use
Has_Warnings_Off.
* sem_elab.adb (Check_Internal_Call_Continue): Likewise.

gcc/ada/sem_ch13.adb
gcc/ada/sem_elab.adb

index 2cdd1573e2173ad274f318b86d1385f32462ef65..4d1644be0492cb5d5940f2d7b24ab54369418471 100644 (file)
@@ -17726,7 +17726,9 @@ package body Sem_Ch13 is
          begin
             --  Skip if function marked as warnings off
 
-            if Warnings_Off (Act_Unit) or else Serious_Errors_Detected > 0 then
+            if Has_Warnings_Off (Act_Unit)
+              or else Serious_Errors_Detected > 0
+            then
                goto Continue;
             end if;
 
index c5303922fcb88954c258e7a61c63017a44bd88fd..b8e3fb6cb88c9c654d69a1f5d3ff0e166c6eb17f 100644 (file)
@@ -18767,9 +18767,9 @@ package body Sem_Elab is
                      T : constant Entity_Id := Etype (First_Formal (E));
                   begin
                      if Is_Controlled (T) then
-                        if Warnings_Off (T)
+                        if Has_Warnings_Off (T)
                           or else (Ekind (T) = E_Private_Type
-                                    and then Warnings_Off (Full_View (T)))
+                                    and then Has_Warnings_Off (Full_View (T)))
                         then
                            goto Output;
                         end if;