]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
cifs: reduce warning log level for server not advertising interfaces
authorShyam Prasad N <sprasad@microsoft.com>
Wed, 13 Mar 2024 10:40:40 +0000 (10:40 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Apr 2024 13:11:27 +0000 (15:11 +0200)
[ Upstream commit 16a57d7681110b25708c7042688412238e6f73a9 ]

Several users have reported this log getting dumped too regularly to
kernel log. The likely root cause has been identified, and it suggests
that this situation is expected for some configurations
(for example SMB2.1).

Since the function returns appropriately even for such cases, it is
fairly harmless to make this a debug log. When needed, the verbosity
can be increased to capture this log.

Cc: stable@vger.kernel.org
Reported-by: Jan Čermák <sairon@sairon.cz>
Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/smb/client/sess.c

index f8f4e7fc05daeb97c1ce761f750e68ea68370fe8..5de32640f0265c128af44da647d042db7343c5ef 100644 (file)
@@ -230,7 +230,7 @@ int cifs_try_adding_channels(struct cifs_ses *ses)
                spin_lock(&ses->iface_lock);
                if (!ses->iface_count) {
                        spin_unlock(&ses->iface_lock);
-                       cifs_dbg(VFS, "server %s does not advertise interfaces\n",
+                       cifs_dbg(ONCE, "server %s does not advertise interfaces\n",
                                      ses->server->hostname);
                        break;
                }
@@ -396,7 +396,7 @@ cifs_chan_update_iface(struct cifs_ses *ses, struct TCP_Server_Info *server)
        spin_lock(&ses->iface_lock);
        if (!ses->iface_count) {
                spin_unlock(&ses->iface_lock);
-               cifs_dbg(VFS, "server %s does not advertise interfaces\n", ses->server->hostname);
+               cifs_dbg(ONCE, "server %s does not advertise interfaces\n", ses->server->hostname);
                return;
        }