Bug 714523 - editversions.cgi should use ->set_all

r=simon, a=simon

diff --git a/Bugzilla/Version.pm b/Bugzilla/Version.pm
index 920853ecdb12f5e0519f31a1f69a14c4c3020da0..317b73d959bff8414c04b42e789c7005183e51f3 100644 (file)
--- a/Bugzilla/Version.pm
+++ b/Bugzilla/Version.pm
@@ -169,8 +169,8 @@ sub product {
 # Validators
 ################################
 
-sub set_name      { $_[0]->set('value', $_[1]);    }
-sub set_is_active { $_[0]->set('isactive', $_[1]); }
+sub set_value    { $_[0]->set('value', $_[1]);    }
+sub set_isactive { $_[0]->set('isactive', $_[1]); }
 
 sub _check_value {
     my ($invocant, $name, undef, $params) = @_;
@@ -219,7 +219,7 @@ Bugzilla::Version - Bugzilla product version class.
     my $version = Bugzilla::Version->create(
         { value => $name, product => $product_obj });
 
-    $version->set_name($new_name);
+    $version->set_value($new_name);
     $version->update();
 
     $version->remove_from_db;
@@ -255,9 +255,9 @@ below.
 
 =item DEFAULT_VERSION
 
-=item set_is_active
+=item set_isactive
 
-=item set_name
+=item set_value
 
 =item product_id
 

diff --git a/editversions.cgi b/editversions.cgi
index 1d056c67b90d8c6cc9bb13f66246af1adc0ced03..06f2f580c2514cd3db4b3cf299cf0f23a0cf0417 100755 (executable)
--- a/editversions.cgi
+++ b/editversions.cgi
@@ -188,8 +188,10 @@ if ($action eq 'update') {
 
     $dbh->bz_start_transaction();
 
-    $version->set_name($version_name);
-    $version->set_is_active($isactive);
+    $version->set_all({
+        value    =>  $version_name,
+        isactive =>  $isactive
+    });
     my $changes = $version->update();
 
     $dbh->bz_commit_transaction();