]> git.ipfire.org Git - thirdparty/vala.git/commitdiff
vala: Move transformation of unary increment/decrement to codegen
authorRico Tzschichholz <ricotz@ubuntu.com>
Thu, 13 Aug 2020 17:05:49 +0000 (19:05 +0200)
committerRico Tzschichholz <ricotz@ubuntu.com>
Thu, 13 Aug 2020 17:05:49 +0000 (19:05 +0200)
In preparation for https://gitlab.gnome.org/GNOME/vala/issues/1061

codegen/valaccodebasemodule.vala
vala/valaunaryexpression.vala

index 084c5eaba557136ed5d74b7f78959e0ff9d8fa51..1021c6f69a6cb3b0ab1d6a493221a377e6568ad9 100644 (file)
@@ -5262,6 +5262,28 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
                        return;
                }
 
+               if (expr.operator == UnaryOperator.INCREMENT || expr.operator == UnaryOperator.DECREMENT) {
+                       // increment/decrement variable
+                       var op = expr.operator == UnaryOperator.INCREMENT ? CCodeBinaryOperator.PLUS : CCodeBinaryOperator.MINUS;
+                       var cexpr = new CCodeBinaryExpression (op, get_cvalue_ (expr.inner.target_value), new CCodeConstant ("1"));
+                       ccode.add_assignment (get_cvalue (expr.inner), cexpr);
+
+                       // assign new value to temp variable
+                       var temp_value = store_temp_value (expr.inner.target_value, expr);
+
+                       MemberAccess ma = find_property_access (expr.inner);
+                       if (ma != null) {
+                               // property postfix expression
+                               var prop = (Property) ma.symbol_reference;
+
+                               store_property (prop, ma.inner, temp_value);
+                       }
+
+                       // return new value
+                       expr.target_value = temp_value;
+                       return;
+               }
+
                CCodeUnaryOperator op;
                switch (expr.operator) {
                case UnaryOperator.PLUS:
index 488cef8e9ad88acd7041c76a5615d8e127a8e1d2..2a010b6b78ffeeaa111bf701e54ab9b8101783bb 100644 (file)
@@ -214,15 +214,8 @@ public class Vala.UnaryExpression : Expression {
                                return false;
                        }
 
-                       var old_value = new MemberAccess (ma.inner, ma.member_name, inner.source_reference);
-                       var bin = new BinaryExpression (operator == UnaryOperator.INCREMENT ? BinaryOperator.PLUS : BinaryOperator.MINUS, old_value, new IntegerLiteral ("1"), source_reference);
-
-                       var assignment = new Assignment (ma, bin, AssignmentOperator.SIMPLE, source_reference);
-                       assignment.target_type = target_type;
-                       context.analyzer.replaced_nodes.add (this);
-                       parent_node.replace_expression (this, assignment);
-                       assignment.check (context);
-                       return true;
+                       value_type = inner.value_type;
+                       break;
                case UnaryOperator.REF:
                case UnaryOperator.OUT:
                        unowned ElementAccess? ea = inner as ElementAccess;