]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: armada-37xx: propagate error from armada_37xx_gpio_get_direction()
authorGabor Juhos <j4g8y7@gmail.com>
Wed, 14 May 2025 19:18:37 +0000 (21:18 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 14 May 2025 22:18:14 +0000 (00:18 +0200)
The regmap_read() function can fail, so propagate its error up to
the stack instead of silently ignoring that.

Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Link: https://lore.kernel.org/20250514-pinctrl-a37xx-fixes-v2-6-07e9ac1ab737@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c

index aed0069b085ced5867993e95e0244df7ccda556d..18c6c5026b26c294ee65e3deea02d2e852e10622 100644 (file)
@@ -402,10 +402,13 @@ static int armada_37xx_gpio_get_direction(struct gpio_chip *chip,
        struct armada_37xx_pinctrl *info = gpiochip_get_data(chip);
        unsigned int reg = OUTPUT_EN;
        unsigned int val, mask;
+       int ret;
 
        armada_37xx_update_reg(&reg, &offset);
        mask = BIT(offset);
-       regmap_read(info->regmap, reg, &val);
+       ret = regmap_read(info->regmap, reg, &val);
+       if (ret)
+               return ret;
 
        if (val & mask)
                return GPIO_LINE_DIRECTION_OUT;