]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
tests: Remove unnecessary second wait from connect_cmd_reject_assoc
authorJouni Malinen <jouni@codeaurora.org>
Fri, 15 Mar 2019 20:42:18 +0000 (22:42 +0200)
committerJouni Malinen <j@w1.fi>
Fri, 15 Mar 2019 21:57:44 +0000 (23:57 +0200)
It does not look like there would be two CTRL-EVENT-ASSOC-REJECT events
here, so only check the first one instead of requiring both to be
received with status_code=27. This test case could fail based on the
second connection attempt (due to that extra event wait) timing out.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
tests/hwsim/test_connect_cmd.py

index d2f66a497b2e331a1593aae43321d19192e0d99c..630ea224f02b48df066e127ee26c011ea222df0c 100644 (file)
@@ -130,14 +130,11 @@ def test_connect_cmd_reject_assoc(dev, apdev):
     wpas.interface_add("wlan5", drv_params="force_connect_cmd=1")
     wpas.connect("sta-connect", key_mgmt="NONE", scan_freq="2412",
                  disable_ht="1", wait_connect=False)
-    # Reject event gets reported twice since we force connect command to be used
-    # with a driver that supports auth+assoc for testing purposes.
-    for i in range(0, 2):
-        ev = wpas.wait_event(["CTRL-EVENT-ASSOC-REJECT"], timeout=15)
-        if ev is None:
-            raise Exception("Association rejection timed out")
-        if "status_code=27" not in ev:
-            raise Exception("Unexpected rejection status code")
+    ev = wpas.wait_event(["CTRL-EVENT-ASSOC-REJECT"], timeout=15)
+    if ev is None:
+        raise Exception("Association rejection timed out")
+    if "status_code=27" not in ev:
+        raise Exception("Unexpected rejection status code")
 
     wpas.request("DISCONNECT")
     wpas.dump_monitor()