]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu_hotplug: Drop dead code in net update
authorJiri Denemark <jdenemar@redhat.com>
Thu, 22 Feb 2018 12:24:58 +0000 (13:24 +0100)
committerJiri Denemark <jdenemar@redhat.com>
Fri, 23 Feb 2018 10:52:44 +0000 (11:52 +0100)
vm->def->nets[changeidx] can never be NULL for changeidx returned by
virDomainNetFindIdx.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
src/qemu/qemu_hotplug.c

index 87cf578acce3482035a55230a6be4556aaf56012..e0a5300f08fafb699fa2217caa4126d78007ba55 100644 (file)
@@ -3061,12 +3061,7 @@ qemuDomainChangeNet(virQEMUDriverPtr driver,
     if ((changeidx = virDomainNetFindIdx(vm->def, newdev)) < 0)
         goto cleanup;
     devslot = &vm->def->nets[changeidx];
-
-    if (!(olddev = *devslot)) {
-        virReportError(VIR_ERR_OPERATION_FAILED, "%s",
-                       _("cannot find existing network device to modify"));
-        goto cleanup;
-    }
+    olddev = *devslot;
 
     oldType = virDomainNetGetActualType(olddev);
     if (oldType == VIR_DOMAIN_NET_TYPE_HOSTDEV) {