Bug 818890: Bugzilla doesn't obey the "Comment required on status transition" for...

r/a=LpSolit

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index f8b4d2142c2cac887635d319b153d82560f5186d..efad66f622865395f824fea2d4e3416a73369b8a 100644 (file)
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -1323,11 +1323,12 @@ sub _check_bug_status {
     }
 
     # Check if a comment is required for this change.
-    if ($new_status->comment_required_on_change_from($old_status) && !$comment)
+    if ($new_status->comment_required_on_change_from($old_status)
+        && !$comment->{'thetext'})
     {
         ThrowUserError('comment_required',
-          { old => $old_status->name, new => $new_status->name,
-            field => 'bug_status' });
+          { old => $old_status ? $old_status->name : undef,
+            new => $new_status->name, field => 'bug_status' });
     }
     
     if (ref $invocant