]> git.ipfire.org Git - thirdparty/Chart.js.git/commitdiff
Stop modifying options in interaction handlers (#9939)
authorJukka Kurkela <jukka.kurkela@gmail.com>
Wed, 1 Dec 2021 22:55:58 +0000 (00:55 +0200)
committerGitHub <noreply@github.com>
Wed, 1 Dec 2021 22:55:58 +0000 (17:55 -0500)
* Stop modifying options in interaction handlers
* Don't use object spread

src/core/core.interaction.js

index 5365f6c9108e56a00ee2c0f2f04fdf42e9514362..0c37d1d8cddfb8e19359502cc8a75aebda6a4206 100644 (file)
@@ -322,8 +322,7 @@ export default {
                 * @return {InteractionItem[]} - items that are found
                 */
     x(chart, e, options, useFinalPosition) {
-      options.axis = 'x';
-      return getAxisItems(chart, e, options, useFinalPosition);
+      return getAxisItems(chart, e, {axis: 'x', intersect: options.intersect}, useFinalPosition);
     },
 
     /**
@@ -336,8 +335,7 @@ export default {
                 * @return {InteractionItem[]} - items that are found
                 */
     y(chart, e, options, useFinalPosition) {
-      options.axis = 'y';
-      return getAxisItems(chart, e, options, useFinalPosition);
+      return getAxisItems(chart, e, {axis: 'y', intersect: options.intersect}, useFinalPosition);
     }
   }
 };