]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm/damon/sysfs: check contexts->nr in repeat_call_fn
authorJosh Law <objecting@objecting.org>
Sat, 21 Mar 2026 17:54:26 +0000 (10:54 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Sat, 28 Mar 2026 03:48:38 +0000 (20:48 -0700)
damon_sysfs_repeat_call_fn() calls damon_sysfs_upd_tuned_intervals(),
damon_sysfs_upd_schemes_stats(), and
damon_sysfs_upd_schemes_effective_quotas() without checking contexts->nr.
If nr_contexts is set to 0 via sysfs while DAMON is running, these
functions dereference contexts_arr[0] and cause a NULL pointer
dereference.  Add the missing check.

For example, the issue can be reproduced using DAMON sysfs interface and
DAMON user-space tool (damo) [1] like below.

    $ sudo damo start --refresh_interval 1s
    $ echo 0 | sudo tee \
            /sys/kernel/mm/damon/admin/kdamonds/0/contexts/nr_contexts

Link: https://patch.msgid.link/20260320163559.178101-3-objecting@objecting.org
Link: https://lkml.kernel.org/r/20260321175427.86000-4-sj@kernel.org
Link: https://github.com/damonitor/damo
Fixes: d809a7c64ba8 ("mm/damon/sysfs: implement refresh_ms file internal work")
Signed-off-by: Josh Law <objecting@objecting.org>
Reviewed-by: SeongJae Park <sj@kernel.org>
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org> [6.17+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/sysfs.c

index ddc30586c0e61391bb7a0cc56727ce62272368ca..6a44a2f3d8fc9d0f5526b52cb053bdd159fe472f 100644 (file)
@@ -1620,9 +1620,12 @@ static int damon_sysfs_repeat_call_fn(void *data)
 
        if (!mutex_trylock(&damon_sysfs_lock))
                return 0;
+       if (sysfs_kdamond->contexts->nr != 1)
+               goto out;
        damon_sysfs_upd_tuned_intervals(sysfs_kdamond);
        damon_sysfs_upd_schemes_stats(sysfs_kdamond);
        damon_sysfs_upd_schemes_effective_quotas(sysfs_kdamond);
+out:
        mutex_unlock(&damon_sysfs_lock);
        return 0;
 }