drm/i915/de: Introduce intel_de.c and move intel_de_{read,write}8() there

intel_de_{read,write}8() aren't performance critical so having them
as static inline is pointless. Introduce intel_de.c and move the
implementation there.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20260313111028.25159-2-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>

diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index be976a90c5a631ba5e7c843d97cd776d4d9699a8..b677720a1c2dba721fcc910a83643996d2ad3299 100644 (file)
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -254,6 +254,7 @@ i915-y += \
        display/intel_crtc_state_dump.o \
        display/intel_cursor.o \
        display/intel_dbuf_bw.o \
+       display/intel_de.o \
        display/intel_display.o \
        display/intel_display_conversion.o \
        display/intel_display_driver.o \

diff --git a/drivers/gpu/drm/i915/display/intel_de.c b/drivers/gpu/drm/i915/display/intel_de.c
new file mode 100644 (file)
index 0000000..5348c1d
--- /dev/null
+++ b/drivers/gpu/drm/i915/display/intel_de.c
@@ -0,0 +1,23 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2026 Intel Corporation
+ */
+
+#include <drm/drm_print.h>
+
+#include "intel_de.h"
+
+u8 intel_de_read8(struct intel_display *display, i915_reg_t reg)
+{
+       /* this is only used on VGA registers (possible on pre-g4x) */
+       drm_WARN_ON(display->drm, DISPLAY_VER(display) >= 5 || display->platform.g4x);
+
+       return intel_uncore_read8(__to_uncore(display), reg);
+}
+
+void intel_de_write8(struct intel_display *display, i915_reg_t reg, u8 val)
+{
+       drm_WARN_ON(display->drm, DISPLAY_VER(display) >= 5 || display->platform.g4x);
+
+       intel_uncore_write8(__to_uncore(display), reg, val);
+}

diff --git a/drivers/gpu/drm/i915/display/intel_de.h b/drivers/gpu/drm/i915/display/intel_de.h
index f30f3f8ebee1dbc289576efa270354a382d0b9a7..8ca5904ba84ed136395ffe9a555de50ee31de278 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_de.h
+++ b/drivers/gpu/drm/i915/display/intel_de.h
@@ -6,8 +6,6 @@
 #ifndef __INTEL_DE_H__
 #define __INTEL_DE_H__
 
-#include <drm/drm_print.h>
-
 #include "intel_display_core.h"
 #include "intel_dmc_wl.h"
 #include "intel_dsb.h"
@@ -19,6 +17,9 @@ static inline struct intel_uncore *__to_uncore(struct intel_display *display)
        return to_intel_uncore(display->drm);
 }
 
+u8 intel_de_read8(struct intel_display *display, i915_reg_t reg);
+void intel_de_write8(struct intel_display *display, i915_reg_t reg, u8 val);
+
 static inline u32
 intel_de_read(struct intel_display *display, i915_reg_t reg)
 {
@@ -33,23 +34,6 @@ intel_de_read(struct intel_display *display, i915_reg_t reg)
        return val;
 }
 
-static inline u8
-intel_de_read8(struct intel_display *display, i915_reg_t reg)
-{
-       /* this is only used on VGA registers (possible on pre-g4x) */
-       drm_WARN_ON(display->drm, DISPLAY_VER(display) >= 5 || display->platform.g4x);
-
-       return intel_uncore_read8(__to_uncore(display), reg);
-}
-
-static inline void
-intel_de_write8(struct intel_display *display, i915_reg_t reg, u8 val)
-{
-       drm_WARN_ON(display->drm, DISPLAY_VER(display) >= 5 || display->platform.g4x);
-
-       intel_uncore_write8(__to_uncore(display), reg, val);
-}
-
 static inline u64
 intel_de_read64_2x32(struct intel_display *display,
                     i915_reg_t lower_reg, i915_reg_t upper_reg)

diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index 468599492af16a9bb905d3973133401d0fd5602b..35d611adbb8332a539378973f8c043e1d2edca56 100644 (file)
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -249,6 +249,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
        i915-display/intel_dbuf_bw.o \
        i915-display/intel_ddi.o \
        i915-display/intel_ddi_buf_trans.o \
+       i915-display/intel_de.o \
        i915-display/intel_display.o \
        i915-display/intel_display_conversion.o \
        i915-display/intel_display_device.o \