]> git.ipfire.org Git - thirdparty/collectd.git/commitdiff
cpu plugin: Ensure unpopulated states return NAN.
authorFlorian Forster <octo@collectd.org>
Fri, 5 Jan 2024 07:03:46 +0000 (08:03 +0100)
committerFlorian Forster <octo@collectd.org>
Mon, 22 Jan 2024 15:07:57 +0000 (16:07 +0100)
src/cpu_test.c

index 8f400923fdf862c3b9e7dbe872df6b6b2b90daec..ad46a3621afcc73c56c07d2310a089cc76b582a2 100644 (file)
@@ -22,7 +22,7 @@
 #include "cpu.c" /* sic */
 #include "testing.h"
 
-DEF_TEST(usage) {
+DEF_TEST(usage_simple_rate) {
   usage_t usage = {0};
 
   cdtime_t t0 = TIME_T_TO_CDTIME_T(100);
@@ -43,12 +43,20 @@ DEF_TEST(usage) {
 
   EXPECT_EQ_DOUBLE(want_rate, usage_rate(usage, 0, STATE_USER));
 
+  // States that we have not set should be NAN
+  for (state_t s = 0; s < STATE_MAX; s++) {
+    if (s == STATE_USER) {
+      continue;
+    }
+    EXPECT_EQ_DOUBLE(NAN, usage_rate(usage, 0, s));
+  }
+
   usage_reset(&usage);
   return 0;
 }
 
 int main(void) {
-  RUN_TEST(usage);
+  RUN_TEST(usage_simple_rate);
 
   END_TEST;
 }