]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
rxrpc: Fix rack timer warning to report unexpected mode
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Wed, 8 Apr 2026 12:12:35 +0000 (13:12 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 9 Apr 2026 01:44:32 +0000 (18:44 -0700)
rxrpc_rack_timer_expired() clears call->rack_timer_mode to OFF before
the switch. The default case warning therefore always prints OFF and
doesn't identify the unexpected timer mode.

Log the saved mode value instead so the warning reports the actual
unexpected rack timer mode.

Fixes: 7c482665931b ("rxrpc: Implement RACK/TLP to deal with transmission stalls [RFC8985]")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Jeffrey Altman <jaltman@auristor.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
cc: stable@kernel.org
Link: https://patch.msgid.link/20260408121252.2249051-8-dhowells@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/rxrpc/input_rack.c

index 13c371261e0a58ae8772adde08925419552602bc..9eb109ffba56e8f485b42e6a8b3d37b0c42fe0c4 100644 (file)
@@ -413,6 +413,6 @@ void rxrpc_rack_timer_expired(struct rxrpc_call *call, ktime_t overran_by)
                break;
        //case RXRPC_CALL_RACKTIMER_ZEROWIN:
        default:
-               pr_warn("Unexpected rack timer %u", call->rack_timer_mode);
+               pr_warn("Unexpected rack timer %u", mode);
        }
 }