]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
- latest mysql 5.7 also crashing on XA recovery, disable
authorMike Bayer <mike_mp@zzzcomputing.com>
Fri, 16 Sep 2016 16:55:33 +0000 (12:55 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Fri, 16 Sep 2016 16:57:59 +0000 (12:57 -0400)
XA recovery for all MySQL

Change-Id: I4f77de521cd80c09fdf97e5bbe5dfd1c830dc3cb

test/engine/test_transaction.py
test/requirements.py

index 4d8d1795a53b43ce90085f2dceb8f1b22f5cc3ed..82a0c63172cea3201dd54d405d04e6acf58ce9f4 100644 (file)
@@ -407,6 +407,9 @@ class TransactionTest(fixtures.TestBase):
     # PG emergency shutdown:
     # select * from pg_prepared_xacts
     # ROLLBACK PREPARED '<xid>'
+    # MySQL emergency shutdown:
+    # for arg in `mysql -u root -e "xa recover" | cut -c 8-100 |
+    #     grep sa`; do mysql -u root -e "xa rollback '$arg'"; done
     @testing.crashes('mysql', 'Crashing on 5.5, not worth it')
     @testing.requires.skip_mysql_on_windows
     @testing.requires.two_phase_transactions
index 9286a415d193c0acd35f3f8db4e9dfd7d30d029d..87e3bb726448de88ff0897130fce0c85220b913b 100644 (file)
@@ -443,11 +443,9 @@ class DefaultRequirements(SuiteRequirements):
     @property
     def two_phase_recovery(self):
         return self.two_phase_transactions + (
-            exclusions.fails_if(
-               lambda config: config.db.name == 'mysql' and (
-                        config.db.dialect._is_mariadb or
-                        config.db.dialect.server_version_info < (5, 7)
-               )
+            skip_if(
+               "mysql",
+               "crashes on most mariadb and mysql versions"
             )
         )