]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
i2c: rk3x: Use HZ_PER_GHZ constant instead of plain number
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 12 Jan 2026 13:46:13 +0000 (14:46 +0100)
committerAndi Shyti <andi.shyti@kernel.org>
Tue, 13 Jan 2026 17:34:33 +0000 (18:34 +0100)
Use defined constant to avoid the possible mistakes and to provide
an additional information on the units.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20260112134900.4142954-6-andriy.shevchenko@linux.intel.com
drivers/i2c/busses/i2c-rk3x.c

index d4e9196445c0302d93014bb6b90bf992f679977c..fcede9f6ed545a710488c44bbaf03328577a718c 100644 (file)
@@ -19,6 +19,7 @@
 #include <linux/of_irq.h>
 #include <linux/spinlock.h>
 #include <linux/clk.h>
+#include <linux/units.h>
 #include <linux/wait.h>
 #include <linux/mfd/syscon.h>
 #include <linux/regmap.h>
@@ -896,13 +897,12 @@ static void rk3x_i2c_adapt_div(struct rk3x_i2c *i2c, unsigned long clk_rate)
 
        clk_disable(i2c->pclk);
 
-       t_low_ns = div_u64(((u64)calc.div_low + 1) * 8 * 1000000000, clk_rate);
-       t_high_ns = div_u64(((u64)calc.div_high + 1) * 8 * 1000000000,
-                           clk_rate);
+       t_low_ns = div_u64(8ULL * HZ_PER_GHZ * (calc.div_low + 1), clk_rate);
+       t_high_ns = div_u64(8ULL * HZ_PER_GHZ * (calc.div_high + 1), clk_rate);
        dev_dbg(i2c->dev,
-               "CLK %lukhz, Req %uns, Act low %lluns high %lluns\n",
-               clk_rate / 1000,
-               1000000000 / t->bus_freq_hz,
+               "CLK %lukHz, Req %luns, Act low %lluns high %lluns\n",
+               clk_rate / HZ_PER_KHZ,
+               HZ_PER_GHZ / t->bus_freq_hz,
                t_low_ns, t_high_ns);
 }