]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
new test catches #9133 and lint fix
authorShan <shan224@gmail.com>
Sat, 21 Jan 2023 22:07:14 +0000 (14:07 -0800)
committerShan <shan224@gmail.com>
Sat, 21 Jan 2023 22:07:14 +0000 (14:07 -0800)
lib/sqlalchemy/dialects/mssql/base.py
test/dialect/mssql/test_compiler.py
test/dialect/mssql/test_reflection.py

index b8fe8a3710ae99f6e892a3cd28cfaf4b497ae10a..eabea88db64e45043ea7efeff2b2f7a2d81c5ef0 100644 (file)
@@ -2875,7 +2875,6 @@ def _owner_plus_db(dialect, schema):
         return _schema_elements(schema)
 
 
-
 _memoized_schema = util.LRUCache()
 
 
index b666c3cba9a10360609ce1296b67470e9b7b9195..00bbc2af45fd7c8c5531367f9ddc8b85b779e989 100644 (file)
@@ -599,20 +599,6 @@ class CompileTest(fixtures.TestBase, AssertsCompiledSQL):
             checkpositional=("bar",),
         )
 
-    def test_schema_single_token_bracketed(self):
-        metadata = MetaData()
-        tbl = Table(
-            "test",
-            metadata,
-            Column("id", Integer, primary_key=True),
-            schema="[abc]",
-        )
-
-        self.assert_compile(
-            select(tbl),
-            "SELECT abc.test.id FROM abc.test",
-        )
-
     def test_schema_many_tokens_one(self):
         metadata = MetaData()
         tbl = Table(
index 1716d68e3945ef4febc5a0419ab2847fa3598c68..2749156f36583a010bbcd72929ce69c27329517d 100644 (file)
@@ -410,6 +410,24 @@ class ReflectionTest(fixtures.TestBase, ComparesTables, AssertsCompiledSQL):
             )
             Table(tname, MetaData(), autoload_with=conn)
 
+    @testing.combinations(
+        ("test_schema"),
+        ("[test_schema]"),
+        argnames="schema_value",
+    )
+    def test_has_table_with_schema_token_comb(
+        self, metadata, connection, schema_value
+    ):
+        tt = Table(
+            'test',
+            metadata,
+            Column("id", Integer),
+            schema=schema_value
+        )
+        tt.create(connection)
+        found_it = inspect(connection).has_table("test", schema=schema_value)
+        eq_(found_it, True)
+
     def test_db_qualified_items(self, metadata, connection):
         Table("foo", metadata, Column("id", Integer, primary_key=True))
         Table(