]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
comedi: multiq3: Add sanity checks for I/O base address
authorIan Abbott <abbotti@mev.co.uk>
Fri, 30 Jan 2026 16:47:51 +0000 (16:47 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Apr 2026 13:49:38 +0000 (15:49 +0200)
The "multiq3" driver uses an admin-supplied configuration option
(`it->options[0]`) to configure the I/O port base address of a Multiq-3
board.  It currently allows any base address to be configured but the
hardware only supports base addresses (configured by on-board jumpers)
in the range 0 to 0x3F0 on 16-byte boundaries.

Add a sanity check to ensure the device is not configured at an
unsupported base address.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://patch.msgid.link/20260130170416.49994-27-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/comedi/drivers/multiq3.c

index ac369e9a262d72af786880b696ceef99fcd4a3b9..3dde3a1876d7e7eba874ae77bef316aabaa0134b 100644 (file)
@@ -259,7 +259,8 @@ static int multiq3_attach(struct comedi_device *dev,
        int ret;
        int i;
 
-       ret = comedi_request_region(dev, it->options[0], 0x10);
+       ret = comedi_check_request_region(dev, it->options[0], 0x10,
+                                         0, 0x3ff, 16);
        if (ret)
                return ret;