renice: exit with non-zero value when arguments cause warnings

This commit also fixes potential error counter wrap, which theoretically
could make command to exit with a success when it internally failed just
correct amount of times.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

diff --git a/sys-utils/renice.c b/sys-utils/renice.c
index 50b16422bdd8713a94f86aaf486db5d5142a44c4..c0378e1a5621bea56206551d69592eef20c388d1 100644 (file)
--- a/sys-utils/renice.c
+++ b/sys-utils/renice.c
@@ -138,6 +138,7 @@ main(int argc, char **argv)
 
                        if (pwd == NULL) {
                                warnx(_("unknown user %s"), *argv);
+                               errs = 1;
                                continue;
                        }
                        who = pwd->pw_uid;
@@ -145,10 +146,11 @@ main(int argc, char **argv)
                        who = strtol(*argv, &endptr, 10);
                        if (who < 0 || *endptr) {
                                warnx(_("bad value %s"), *argv);
+                               errs = 1;
                                continue;
                        }
                }
-               errs += donice(which, who, prio);
+               errs |= donice(which, who, prio);
        }
        return errs != 0 ? EXIT_FAILURE : EXIT_SUCCESS;
 }