tools/cgxget: fix the resource leak in convert_cgroup()

Fix a resource leak warning reported by the Coverity tool:

CID 258272 (#1-2 of 2): Resource leak (RESOURCE_LEAK). leaked_storage:
Variable cg_converted_list going out of scope leaks the storage it
points to.

while free'ing() the cg_converted_list() via cgroup_free(), wrong array
index variable was passed, causing the resource leak. Fix it by passing
the right index variable.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

diff --git a/src/tools/cgxget.c b/src/tools/cgxget.c
index 0a8cbc5605f86a0a47ff36eed2a85dfd57fefc4a..96fe79b4d915517a1fd29c321c3e3cc581be6b66 100644 (file)
--- a/src/tools/cgxget.c
+++ b/src/tools/cgxget.c
@@ -769,7 +769,7 @@ out:
        if (ret != 0 && ret != ECGNOVERSIONCONVERT) {
                /* The conversion failed */
                for (j = 0; j < i; j++)
-                       cgroup_free(&(cg_converted_list[i]));
+                       cgroup_free(&(cg_converted_list[j]));
        } else {
                /*
                 * The conversion succeeded or was unmappable.