]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
NFSv4: fix getacl head length estimation
authorJ. Bruce Fields <bfields@redhat.com>
Thu, 23 Feb 2017 19:53:39 +0000 (14:53 -0500)
committerJiri Slaby <jslaby@suse.cz>
Mon, 13 Mar 2017 20:40:37 +0000 (21:40 +0100)
commit 6682c14bbe505a8b912c57faf544f866777ee48d upstream.

Bitmap and attrlen follow immediately after the op reply header.  This
was an oversight from commit bf118a342f.

Consequences of this are just minor efficiency (extra calls to
xdr_shrink_bufhead).

Fixes: bf118a342f10 "NFSv4: include bitmap in nfsv4 get acl data"
Reviewed-by: Kinglong Mee <kinglongmee@gmail.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
fs/nfs/nfs4xdr.c

index 1c2beb18a71304149b44814bf09145073c0ce0cd..a31b34936d937d68307e3ac2eac6e4fd6bca1b5a 100644 (file)
@@ -2486,7 +2486,7 @@ static void nfs4_xdr_enc_getacl(struct rpc_rqst *req, struct xdr_stream *xdr,
        encode_compound_hdr(xdr, req, &hdr);
        encode_sequence(xdr, &args->seq_args, &hdr);
        encode_putfh(xdr, args->fh, &hdr);
-       replen = hdr.replen + op_decode_hdr_maxsz + 1;
+       replen = hdr.replen + op_decode_hdr_maxsz;
        encode_getattr_two(xdr, FATTR4_WORD0_ACL, 0, &hdr);
 
        xdr_inline_pages(&req->rq_rcv_buf, replen << 2,