]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
address resource leak; don't call close() on socket error;
authorMark Andrews <marka@isc.org>
Mon, 19 Nov 2018 01:27:56 +0000 (12:27 +1100)
committerMark Andrews <marka@isc.org>
Thu, 22 Nov 2018 23:34:59 +0000 (10:34 +1100)
lib/isc/unix/socket.c

index ff9efe535c7a969f952ff7cdbfb4aeaa1093e5ae..7e1c616afdb07abe11854c9526ad11ac1129c92a 100644 (file)
@@ -5453,7 +5453,6 @@ init_hasreuseport() {
        int sock, yes = 1;
        sock = socket(AF_INET, SOCK_DGRAM, 0);
        if (sock < 0) {
-               close(sock);
                return;
        } else if (setsockopt(sock, SOL_SOCKET, SO_REUSEADDR,
                              (void *)&yes, sizeof(yes)) < 0)
@@ -5467,6 +5466,7 @@ init_hasreuseport() {
                return;
        }
        hasreuseport = true;
+       close(sock);
 #endif
 }