]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
USB: adutux: remove redundant variable minor
authorColin Ian King <colin.king@canonical.com>
Tue, 7 Nov 2017 11:45:27 +0000 (11:45 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 10 Dec 2019 18:01:34 +0000 (18:01 +0000)
commit 8444efc4a052332d643ed5c8aebcca148c7de032 upstream.

Variable minor is being assigned but never read, hence it is redundant
and can be removed. Cleans up clang warning:

drivers/usb/misc/adutux.c:770:2: warning: Value stored to 'minor' is
never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[bwh: Backported to 3.16 so that commit 44efc269db79 "USB: adutux: fix
 use-after-free on disconnect" applies cleanly]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/misc/adutux.c

index 5cfaf69bc62f8f77e2e6492758222e3ace63b191..f6f7372dd2fb1e8dfe810363512df4cae895850e 100644 (file)
@@ -796,13 +796,11 @@ error:
 static void adu_disconnect(struct usb_interface *interface)
 {
        struct adu_device *dev;
-       int minor;
 
        dev = usb_get_intfdata(interface);
 
        mutex_lock(&dev->mtx);  /* not interruptible */
        dev->udev = NULL;       /* poison */
-       minor = dev->minor;
        usb_deregister_dev(interface, &adu_class);
        mutex_unlock(&dev->mtx);