malloc: Check for integer overflow in memalign.

A large bytes parameter to memalign could cause an integer overflow
and corrupt allocator internals. Check the overflow does not occur
before continuing with the allocation.

ChangeLog:

2013-09-11  Will Newton  <will.newton@linaro.org>

	[BZ #15857]
	* malloc/malloc.c (__libc_memalign): Check the value of bytes
	does not overflow.

diff --git a/ChangeLog b/ChangeLog
index 4ec9ada9785c1439e62eaa9e692ef49c86e3efc5..9698a1d55a1251aac9a70cfd9d7620f2534116f9 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2013-09-11  Will Newton  <will.newton@linaro.org>
+
+       [BZ #15857]
+       * malloc/malloc.c (__libc_memalign): Check the value of bytes
+       does not overflow.
+
 2013-09-11  Will Newton  <will.newton@linaro.org>
 
        [BZ #15856]

diff --git a/malloc/malloc.c b/malloc/malloc.c
index 31e2dfad91e1f766ea57f1681fd8db0109473163..ebbe86dc7c3f461faa0b8f61d1d078101839a8cd 100644 (file)
--- a/malloc/malloc.c
+++ b/malloc/malloc.c
@@ -3015,6 +3015,13 @@ __libc_memalign(size_t alignment, size_t bytes)
   /* Otherwise, ensure that it is at least a minimum chunk size */
   if (alignment <  MINSIZE) alignment = MINSIZE;
 
+  /* Check for overflow.  */
+  if (bytes > SIZE_MAX - alignment - MINSIZE)
+    {
+      __set_errno (ENOMEM);
+      return 0;
+    }
+
   arena_get(ar_ptr, bytes + alignment + MINSIZE);
   if(!ar_ptr)
     return 0;