soc: fsl: qe: Simplify with scoped for each OF child loop

Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Acked-by: Herve Codina <herve.codina@bootlin.com>
Link: https://lore.kernel.org/r/20260102124754.64122-2-krzysztof.kozlowski@oss.qualcomm.com
Signed-off-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>

diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
index da5ea6d3561840810592fb327b93aced1f68dde3..c4587b32a59bfa2652a581c62b3fdd871f3471b9 100644 (file)
--- a/drivers/soc/fsl/qe/qmc.c
+++ b/drivers/soc/fsl/qe/qmc.c
@@ -1284,31 +1284,26 @@ static unsigned int qmc_nb_chans(struct qmc *qmc)
 
 static int qmc_of_parse_chans(struct qmc *qmc, struct device_node *np)
 {
-       struct device_node *chan_np;
        struct qmc_chan *chan;
        const char *mode;
        u32 chan_id;
        u64 ts_mask;
        int ret;
 
-       for_each_available_child_of_node(np, chan_np) {
+       for_each_available_child_of_node_scoped(np, chan_np) {
                ret = of_property_read_u32(chan_np, "reg", &chan_id);
                if (ret) {
                        dev_err(qmc->dev, "%pOF: failed to read reg\n", chan_np);
-                       of_node_put(chan_np);
                        return ret;
                }
                if (chan_id > 63) {
                        dev_err(qmc->dev, "%pOF: Invalid chan_id\n", chan_np);
-                       of_node_put(chan_np);
                        return -EINVAL;
                }
 
                chan = devm_kzalloc(qmc->dev, sizeof(*chan), GFP_KERNEL);
-               if (!chan) {
-                       of_node_put(chan_np);
+               if (!chan)
                        return -ENOMEM;
-               }
 
                chan->id = chan_id;
                spin_lock_init(&chan->ts_lock);
@@ -1319,7 +1314,6 @@ static int qmc_of_parse_chans(struct qmc *qmc, struct device_node *np)
                if (ret) {
                        dev_err(qmc->dev, "%pOF: failed to read fsl,tx-ts-mask\n",
                                chan_np);
-                       of_node_put(chan_np);
                        return ret;
                }
                chan->tx_ts_mask_avail = ts_mask;
@@ -1329,7 +1323,6 @@ static int qmc_of_parse_chans(struct qmc *qmc, struct device_node *np)
                if (ret) {
                        dev_err(qmc->dev, "%pOF: failed to read fsl,rx-ts-mask\n",
                                chan_np);
-                       of_node_put(chan_np);
                        return ret;
                }
                chan->rx_ts_mask_avail = ts_mask;
@@ -1340,7 +1333,6 @@ static int qmc_of_parse_chans(struct qmc *qmc, struct device_node *np)
                if (ret && ret != -EINVAL) {
                        dev_err(qmc->dev, "%pOF: failed to read fsl,operational-mode\n",
                                chan_np);
-                       of_node_put(chan_np);
                        return ret;
                }
                if (!strcmp(mode, "transparent")) {
@@ -1350,7 +1342,6 @@ static int qmc_of_parse_chans(struct qmc *qmc, struct device_node *np)
                } else {
                        dev_err(qmc->dev, "%pOF: Invalid fsl,operational-mode (%s)\n",
                                chan_np, mode);
-                       of_node_put(chan_np);
                        return -EINVAL;
                }