Fixes missing lxml and tweaks commenting

diff --git a/build-docker-image.sh b/build-docker-image.sh
index c7411d962c3fcb4e361f44e9446cde0033baab47..c43c9886b67798a39c96ce3765cc8e033209d580 100755 (executable)
--- a/build-docker-image.sh
+++ b/build-docker-image.sh
@@ -24,6 +24,7 @@ fi
 pikepdf_version=$(jq ".default.pikepdf.version" Pipfile.lock  | sed 's/=//g' | sed 's/"//g')
 psycopg2_version=$(jq ".default.psycopg2.version" Pipfile.lock | sed 's/=//g' | sed 's/"//g')
 pillow_version=$(jq ".default.pillow.version" Pipfile.lock | sed 's/=//g' | sed 's/"//g')
+lxml_version=$(jq ".default.lxml.version" Pipfile.lock | sed 's/=//g' | sed 's/"//g')
 # Read this from the other config file
 qpdf_version=$(jq ".qpdf.version" .build-config.json | sed 's/"//g')
 jbig2enc_version=$(jq ".jbig2enc.version" .build-config.json | sed 's/"//g')
@@ -42,4 +43,5 @@ docker build --file "$1" \
        --build-arg QPDF_VERSION="${qpdf_version}" \
        --build-arg PIKEPDF_VERSION="${pikepdf_version}" \
        --build-arg PILLOW_VERSION="${pillow_version}" \
+       --build-arg LXML_VERSION="${lxml_version}" \
        --build-arg PSYCOPG2_VERSION="${psycopg2_version}" "${@:2}" .

diff --git a/docker-builders/Dockerfile.pikepdf b/docker-builders/Dockerfile.pikepdf
index 4248bd334003f7511066421c313ac00a3e83ec15..2594f71f521337700e2040d97223e0c2da0e1006 100644 (file)
--- a/docker-builders/Dockerfile.pikepdf
+++ b/docker-builders/Dockerfile.pikepdf
@@ -18,7 +18,7 @@ LABEL org.opencontainers.image.description="A intermediate image with pikepdf wh
 
 ARG DEBIAN_FRONTEND=noninteractive
 ARG PIKEPDF_VERSION
-# These not not used, but will still bust the cache if one changes
+# These are not used, but will still bust the cache if one changes
 # Otherwise, the main image will try to build thing (and fail)
 ARG PILLOW_VERSION
 ARG LXML_VERSION