]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
moved rollback catch to mysql module...
authorMike Bayer <mike_mp@zzzcomputing.com>
Thu, 10 Aug 2006 19:17:45 +0000 (19:17 +0000)
committerMike Bayer <mike_mp@zzzcomputing.com>
Thu, 10 Aug 2006 19:17:45 +0000 (19:17 +0000)
lib/sqlalchemy/databases/mysql.py
lib/sqlalchemy/engine/default.py

index 7e337b9a3571adf8ebed3d62ba2275d21a110023..2ce7e98259af1c3d4a9a22554f5aef35d48cd76e 100644 (file)
@@ -297,6 +297,13 @@ class MySQLDialect(ansisql.ANSIDialect):
     def schemadropper(self, *args, **kwargs):
         return MySQLSchemaDropper(*args, **kwargs)
 
+    def do_rollback(self, connection):
+        # some versions of MySQL just dont support rollback() at all....
+        try:
+            connection.rollback()
+        except:
+            pass
+
     def get_default_schema_name(self):
         if not hasattr(self, '_default_schema_name'):
             self._default_schema_name = text("select database()", self).scalar()
index 2f8e1c2289940ad68465c1a3f8b09ab34bc74192..f0ffd7797e2f10d4b6712d874d5d39fb631e7cf1 100644 (file)
@@ -73,10 +73,7 @@ class DefaultDialect(base.Dialect):
         """implementations might want to put logic here for turning autocommit on/off,
         etc."""
         #print "ENGINE ROLLBACK ON ", connection.connection
-        try:
-            connection.rollback()
-        except:
-            pass
+        connection.rollback()
     def do_commit(self, connection):
         """implementations might want to put logic here for turning autocommit on/off, etc."""
         #print "ENGINE COMMIT ON ", connection.connection