]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
checkpatch: cuppress warnings when Reported-by: is followed by Link:
authorCryolitia PukNgae <cryolitia@uniontech.com>
Fri, 5 Jun 2026 06:57:04 +0000 (14:57 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 11 Jun 2026 18:42:21 +0000 (11:42 -0700)
> The tag should be followed by a Closes: tag pointing to the report,
> unless the report is not available on the web. The Link: tag can be
> used instead of Closes: if the patch fixes a part of the issue(s)
> being reported.

According to Documentation/process/submitting-patches.rst, Link: is also
acceptable to follow a Reported-by:, if the patch fixes a part of the
issue(s) being reported.

Link: https://lore.kernel.org/20260605-checkpatch-v1-1-8c68ae618513@linux.dev
Signed-off-by: Cryolitia PukNgae <cryolitia@uniontech.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Cheng Nie <niecheng1@uniontech.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: Joe Perches <joe@perches.com>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
scripts/checkpatch.pl

index 3727156e4ccadb0ecdf2b26c37358ad0ddc2283f..d9af266c63df062361592bf0e76790346a299161 100755 (executable)
@@ -3253,10 +3253,10 @@ sub process {
                        if ($sign_off =~ /^reported(?:|-and-tested)-by:$/i) {
                                if (!defined $lines[$linenr]) {
                                        WARN("BAD_REPORTED_BY_LINK",
-                                            "Reported-by: should be immediately followed by Closes: with a URL to the report\n" . $herecurr . "\n");
-                               } elsif ($rawlines[$linenr] !~ /^closes:\s*/i) {
+                                            "Reported-by: should be immediately followed by Closes: or Link: with a URL to the report\n" . $herecurr . "\n");
+                               } elsif ($rawlines[$linenr] !~ /^(closes|link):\s*/i) {
                                        WARN("BAD_REPORTED_BY_LINK",
-                                            "Reported-by: should be immediately followed by Closes: with a URL to the report\n" . $herecurr . $rawlines[$linenr] . "\n");
+                                            "Reported-by: should be immediately followed by Closes: or Link: with a URL to the report\n" . $herecurr . $rawlines[$linenr] . "\n");
                                }
                        }
                }