]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
staging:iio:ad799x fix error_free_irq which was freeing an irq that may not have...
authorHartmut Knaack <knaack.h@gmx.de>
Wed, 1 Jan 2014 23:04:00 +0000 (23:04 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 Feb 2014 21:34:50 +0000 (13:34 -0800)
commit 38408d056188be29a6c4e17f3703c796551bb330 upstream.

Only free an IRQ in error_free_irq, if it has been requested previously.

Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/iio/adc/ad799x_core.c

index 9428be82b655f0d6456e5d4c0dec3d0d6661dcc2..85b3b782d5150097685eb77306022072612267ad 100644 (file)
@@ -588,7 +588,8 @@ static int ad799x_probe(struct i2c_client *client,
        return 0;
 
 error_free_irq:
-       free_irq(client->irq, indio_dev);
+       if (client->irq > 0)
+               free_irq(client->irq, indio_dev);
 error_cleanup_ring:
        ad799x_ring_cleanup(indio_dev);
 error_disable_reg: