]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: typec: class: Invalidate USB device pointers on partner unregistration
authorAndrei Kuchynski <akuchynski@chromium.org>
Fri, 21 Mar 2025 14:37:27 +0000 (14:37 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Apr 2025 12:57:36 +0000 (14:57 +0200)
To avoid using invalid USB device pointers after a Type-C partner
disconnects, this patch clears the pointers upon partner unregistration.
This ensures a clean state for future connections.

Cc: stable@vger.kernel.org
Fixes: 59de2a56d127 ("usb: typec: Link enumerated USB devices with Type-C partner")
Signed-off-by: Andrei Kuchynski <akuchynski@chromium.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
Link: https://lore.kernel.org/r/20250321143728.4092417-3-akuchynski@chromium.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/class.c

index eadb150223f8f86daf12d87ad9f180bc8af9e0c1..3df3e373691620c4e5cd0cb203027a7f5e770a8d 100644 (file)
@@ -1086,10 +1086,14 @@ void typec_unregister_partner(struct typec_partner *partner)
        port = to_typec_port(partner->dev.parent);
 
        mutex_lock(&port->partner_link_lock);
-       if (port->usb2_dev)
+       if (port->usb2_dev) {
                typec_partner_unlink_device(partner, port->usb2_dev);
-       if (port->usb3_dev)
+               port->usb2_dev = NULL;
+       }
+       if (port->usb3_dev) {
                typec_partner_unlink_device(partner, port->usb3_dev);
+               port->usb3_dev = NULL;
+       }
 
        device_unregister(&partner->dev);
        mutex_unlock(&port->partner_link_lock);