]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mailbox: zynqmp-ipi: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Wed, 24 Dec 2025 11:44:54 +0000 (12:44 +0100)
committerJassi Brar <jassisinghbrar@gmail.com>
Sun, 25 Jan 2026 00:42:40 +0000 (18:42 -0600)
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
drivers/mailbox/zynqmp-ipi-mailbox.c

index 967967b2b8a967ab97c00a50db4ba418735f8e83..42d2583e44ca7fce125d9357d0565157993bf9a7 100644 (file)
@@ -904,7 +904,7 @@ static void zynqmp_ipi_free_mboxes(struct zynqmp_ipi_pdata *pdata)
 static int zynqmp_ipi_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
-       struct device_node *nc, *np = pdev->dev.of_node;
+       struct device_node *np = pdev->dev.of_node;
        struct zynqmp_ipi_pdata *pdata;
        struct of_phandle_args out_irq;
        struct zynqmp_ipi_mbox *mbox;
@@ -940,13 +940,12 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
        pdata->num_mboxes = num_mboxes;
 
        mbox = pdata->ipi_mboxes;
-       for_each_available_child_of_node(np, nc) {
+       for_each_available_child_of_node_scoped(np, nc) {
                mbox->pdata = pdata;
                mbox->setup_ipi_fn = ipi_fn;
 
                ret = zynqmp_ipi_mbox_probe(mbox, nc);
                if (ret) {
-                       of_node_put(nc);
                        dev_err(dev, "failed to probe subdev.\n");
                        ret = -EINVAL;
                        goto free_mbox_dev;