autoreconf: don’t error out when AM_GNU_GETTEXT is used alone.

Some projects intentionally don't call AM_GNU_GETTEXT_(REQUIRE_)VERSION
because they have all of the gettext infrastructure checked into version
control and they want autoreconf to _not_ run autopoint.  Therefore, make
the “AM_GNU_GETTEXT is used, but not AM_GNU_GETTEXT_(REQUIRE_)VERSION”
and “AM_GNU_GETTEXT_(REQUIRE_)VERSION is used, but not AM_GNU_GETTEXT”
diagnostics be warnings again, as they were in 2.69.

(Technically these diagnostics were always errors, in the sense that
they were reported with a call to Autom4te::Channels::error(), but
prior to 2.70, error() calls made by autoreconf did not cause
autoreconf to exit unsuccessfully, due to an unrelated bug.  So people
came to depend on these diagnostics not being fatal.)

diff --git a/bin/autoreconf.in b/bin/autoreconf.in
index bb9f316d72dc0feea1d8712d8f3846ee1ed1611b..9855efbe9fb3ec6df90dbdf8eb12d4e28df22e7b 100644 (file)
--- a/bin/autoreconf.in
+++ b/bin/autoreconf.in
@@ -644,14 +644,18 @@ sub autoreconf_current_directory ($)
        }
     }
 
-  # Gettext consistency checks...
-  error($configure_ac,
-        "AM_GNU_GETTEXT is used, but not AM_GNU_GETTEXT_VERSION"
-        . " or AM_GNU_GETTEXT_REQUIRE_VERSION")
+  # Gettext consistency checks.
+  # Some projects intentionally don't call AM_GNU_GETTEXT_(REQUIRE_)VERSION
+  # because they have all of the gettext infrastructure checked into version
+  # control and they want us to _not_ run autopoint.  Therefore, these
+  # diagnostics are only warnings.
+  msg('syntax', $configure_ac,
+      "AM_GNU_GETTEXT is used, but not AM_GNU_GETTEXT_VERSION"
+      . " or AM_GNU_GETTEXT_REQUIRE_VERSION")
     if $uses_gettext_via_traces && ! $uses_gettext;
-  error($configure_ac,
-        "AM_GNU_GETTEXT_VERSION or AM_GNU_GETTEXT_REQUIRE_VERSION is used,"
-        . " but not AM_GNU_GETTEXT")
+  msg('syntax', $configure_ac,
+      "AM_GNU_GETTEXT_VERSION or AM_GNU_GETTEXT_REQUIRE_VERSION is used,"
+      . " but not AM_GNU_GETTEXT")
     if $uses_gettext && ! $uses_gettext_via_traces;