]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: spacemit: use `depends on` instead of `select`
authorTroy Mitchell <troy.mitchell@linux.spacemit.com>
Tue, 28 Oct 2025 01:32:10 +0000 (09:32 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 28 Oct 2025 10:17:35 +0000 (10:17 +0000)
Selecting DMA_CMA directly bypasses its dependency chain.
This can cause build warnings or errors if the required
dependencies are not enabled.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/all/20251022141705.714b19b5@canb.auug.org.au/
Fixes: fce217449075 ("ASoC: spacemit: add i2s support for K1 SoC")
Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Link: https://patch.msgid.link/20251028-fix-k1-i2s-v2-2-a547c15ed5c3@linux.spacemit.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/spacemit/Kconfig

index 2179f94f3f179c54cd06e6ced5523ed3f5225cf4..e11f600a327f58681ce46df6e0e7a70f5f1d1234 100644 (file)
@@ -6,8 +6,7 @@ menu "SpacemiT"
 config SND_SOC_K1_I2S
        tristate "K1 I2S Device Driver"
        select SND_SOC_GENERIC_DMAENGINE_PCM
-       select CMA
-       select DMA_CMA
+       depends on DMA_CMA
        help
          Say Y or M if you want to add support for I2S driver for
          K1 I2S controller. The device supports up to maximum of