codegen: Don't create null-safe destroy-wrapper for GenericType

https://bugzilla.gnome.org/show_bug.cgi?id=791283

diff --git a/codegen/valaccodebasemodule.vala b/codegen/valaccodebasemodule.vala
index 669c950196e5394bb740acdd830d950d0ac588f5..d8a6329937433dddc92df7e37a1561073b9dcfe7 100644 (file)
--- a/codegen/valaccodebasemodule.vala
+++ b/codegen/valaccodebasemodule.vala
@@ -3066,7 +3066,7 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
        public CCodeExpression? get_destroy0_func_expression (DataType type, bool is_chainup = false) {
                var element_destroy_func_expression = get_destroy_func_expression (type, is_chainup);
 
-               if (element_destroy_func_expression is CCodeIdentifier) {
+               if (!(type is GenericType) && element_destroy_func_expression is CCodeIdentifier) {
                        var freeid = (CCodeIdentifier) element_destroy_func_expression;
                        string free0_func = "_%s0_".printf (freeid.name);
 

diff --git a/tests/Makefile.am b/tests/Makefile.am
index f9cee739138a95068d9d7944af626a2ea2f0a11f..270ba369f4156e2d6ec575805ca05cc5818aca16 100644 (file)
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -78,6 +78,7 @@ TESTS = \
        methods/bug743877.vala \
        methods/bug771964.vala \
        methods/bug791215.vala \
+       methods/bug791283.vala \
        methods/generics.vala \
        control-flow/break.vala \
        control-flow/expressions-conditional.vala \

diff --git a/tests/methods/bug791283.vala b/tests/methods/bug791283.vala
new file mode 100644 (file)
index 0000000..569d8b1
--- /dev/null
+++ b/tests/methods/bug791283.vala
@@ -0,0 +1,16 @@
+class Foo<T> {
+       GenericArray<T> bar;
+
+       public Foo () {
+               bar = new GenericArray<T> ();
+       }
+}
+
+GenericArray<G> create_bar<G> () {
+       return new GenericArray<G> ();
+}
+
+void main () {
+       var foo = new Foo<string> ();
+       var bar = create_bar<int?> ();
+}