- callcount

- more inlining

diff --git a/lib/sqlalchemy/orm/mapper.py b/lib/sqlalchemy/orm/mapper.py
index 54d6a53e270f0c6781fa250251136d22b405d0cf..05e904a0dee29094afaa7ccb5fa1ba388d263405 100644 (file)
--- a/lib/sqlalchemy/orm/mapper.py
+++ b/lib/sqlalchemy/orm/mapper.py
@@ -1833,13 +1833,15 @@ class Mapper(object):
 
                     if primary_key is not None:
                         # set primary key attributes
-                        for i, col in enumerate(mapper._pks_by_table[table]):
-                            if mapper._get_state_attr_by_column(
-                                        state, state_dict, col) \
-                                        is None and len(primary_key) > i:
-                                mapper._set_state_attr_by_column(
-                                        state, state_dict, col,
-                                        primary_key[i])
+                        for pk, col in zip(primary_key, mapper._pks_by_table[table]):
+                            # TODO: make sure this inlined code is OK
+                            # with composites
+                            prop = mapper._columntoproperty[col]
+                            if state_dict.get(prop.key) is None:
+                                # TODO: would rather say:
+                                # state_dict[prop.key] = pk
+                                # here, one test fails
+                                prop._setattr(state, state_dict, pk, col)
                                 
                     mapper._postfetch(uowtransaction, table, 
                                         state, state_dict, c,

diff --git a/lib/sqlalchemy/orm/properties.py b/lib/sqlalchemy/orm/properties.py
index c2f88f9ed0bf4e69d99a085627675aa46ac53a8c..776ecaf99548e6f024e5bc4636e23fd7006066d3 100644 (file)
--- a/lib/sqlalchemy/orm/properties.py
+++ b/lib/sqlalchemy/orm/properties.py
@@ -124,7 +124,7 @@ class ColumnProperty(StrategizedProperty):
                     get_committed_value(state, dict_, passive=passive)
 
     def _setattr(self, state, dict_, value, column):
-        state.get_impl(self.key).set(state, dict_, value, None)
+        state.manager[self.key].impl.set(state, dict_, value, None)
 
     def merge(self, session, source_state, source_dict, dest_state, 
                                 dest_dict, load, _recursive):

diff --git a/test/aaa_profiling/test_orm.py b/test/aaa_profiling/test_orm.py
index bea66c07235bace4e0d9961967a252973761b22b..a3bf816317919719df279b8bcf33285a0612dc61 100644 (file)
--- a/test/aaa_profiling/test_orm.py
+++ b/test/aaa_profiling/test_orm.py
@@ -79,7 +79,9 @@ class MergeTest(_base.MappedTest):
         # using sqlite3 the C extension took it back up to approx. 1257
         # (py2.6)
 
-        @profiling.function_call_count(1257, versions={'2.4': 807})
+        @profiling.function_call_count(1257, 
+                                versions={'2.6+cextension':1194, '2.4': 807}
+                            )
         def go():
             p2 = sess2.merge(p1)
         go()