mailbox: pcc: Remove spurious IRQF_ONESHOT usage

The PCC code currently specifies IRQF_ONESHOT if the interrupt could
potentially be shared but doesn't actually use request_threaded_irq() and
the interrupt handler does not use IRQ_WAKE_THREAD so IRQF_ONESHOT is
never relevant. Since commit aef30c8d569c ("genirq: Warn about using
IRQF_ONESHOT without a threaded handler") specifying it has resulted in a
WARN_ON(), fix this by removing IRQF_ONESHOT.

Reported-by: Aishwarya TCV <Aishwarya.TCV@arm.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>

diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
index 967eb249f40d9fae3c40ce6a160f81e9bbdbce3f..22e70af1ae5d14e6e8c684fe032c2864f6ae4d6c 100644 (file)
--- a/drivers/mailbox/pcc.c
+++ b/drivers/mailbox/pcc.c
@@ -475,7 +475,7 @@ static int pcc_startup(struct mbox_chan *chan)
 
        if (pchan->plat_irq > 0) {
                irqflags = pcc_chan_plat_irq_can_be_shared(pchan) ?
-                                               IRQF_SHARED | IRQF_ONESHOT : 0;
+                                               IRQF_SHARED : 0;
                rc = devm_request_irq(chan->mbox->dev, pchan->plat_irq, pcc_mbox_irq,
                                      irqflags, MBOX_IRQ_NAME, chan);
                if (unlikely(rc)) {