]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
AP MLD: Fix use of a wrong list during link reconf response ack failure
authorManish Dharanenthiran <manish.dharanenthiran@oss.qualcomm.com>
Fri, 28 Nov 2025 10:43:24 +0000 (16:13 +0530)
committerJouni Malinen <j@w1.fi>
Mon, 1 Dec 2025 17:34:56 +0000 (19:34 +0200)
When an ADD_LINK reconfiguration response is not ACKed by the STA, added
links must be reverted. The revert path in
hostapd_link_reconf_resp_tx_status() incorrectly iterates the del_req
list instead of add_req, preventing proper cleanup of station.

Fix this by iterating over req_list->add_req to remove added link STAs
on ack failure instead of del_req.

Fixes: ea7af69a2369 ("AP MLD: Process TX status for Link Reconfiguration Response frame")
Signed-off-by: Govindaraj Saminathan <gsaminat@qti.qualcomm.com>
Signed-off-by: Manish Dharanenthiran <manish.dharanenthiran@oss.qualcomm.com>
src/ap/ieee802_11_eht.c

index ac36c9c48cb8f4730f13a83276763997e64b4fe4..9c8655e7ab506d39a8c541e77cf327686562b6e9 100644 (file)
@@ -1577,7 +1577,7 @@ void hostapd_link_reconf_resp_tx_status(struct hostapd_data *hapd,
                           "; revert link additions",
                           MAC2STR(mgmt->da));
 
-               dl_list_for_each(info, &req_list->del_req,
+               dl_list_for_each(info, &req_list->add_req,
                                 struct link_reconf_req_info, list) {
                        if (info->status != WLAN_STATUS_SUCCESS)
                                continue;