]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
watchdog: keembay: Removed timeout update in the TO ISR
authorShruthi Sanil <shruthi.sanil@intel.com>
Mon, 17 May 2021 17:49:50 +0000 (23:19 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:02:19 +0000 (16:02 +0200)
[ Upstream commit 3168be5d66ac6c3508a880022f79b5a887865d5d ]

In the TO ISR removed updating the Timeout value because
its not serving any purpose as the timer would have already expired
and the system would be rebooting.

Fixes: fa0f8d51e90d ("watchdog: Add watchdog driver for Intel Keembay Soc")
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Kris Pan <kris.pan@intel.com>
Signed-off-by: Shruthi Sanil <shruthi.sanil@intel.com>
Link: https://lore.kernel.org/r/20210517174953.19404-7-shruthi.sanil@intel.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/watchdog/keembay_wdt.c

index 039753b9932be40911290f04dadc6cb59bc884a0..dd192b8dff5511f5a5935651bb3db7bb193f40da 100644 (file)
@@ -141,7 +141,6 @@ static irqreturn_t keembay_wdt_to_isr(int irq, void *dev_id)
        struct keembay_wdt *wdt = dev_id;
        struct arm_smccc_res res;
 
-       keembay_wdt_writel(wdt, TIM_WATCHDOG, 1);
        arm_smccc_smc(WDT_ISR_CLEAR, WDT_TO_INT_MASK, 0, 0, 0, 0, 0, 0, &res);
        dev_crit(wdt->wdd.parent, "Intel Keem Bay non-sec wdt timeout.\n");
        emergency_restart();