]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
stats: Populate group_by field earlier in settings check
authorAki Tuomi <aki.tuomi@open-xchange.com>
Tue, 31 Jan 2023 11:51:36 +0000 (13:51 +0200)
committerAki Tuomi <aki.tuomi@open-xchange.com>
Thu, 16 Mar 2023 05:38:57 +0000 (07:38 +0200)
This is needed in next commit to avoid crash.

src/stats/stats-settings.c

index 4ca9abfe377506d78b25ca9042b2b9bd576dad50..78402d078092a99b7825650cf012727a29994d88 100644 (file)
@@ -459,6 +459,7 @@ static bool parse_metric_group_by(struct stats_metric_settings *set,
 
                /* <field name>:<aggregation func>... */
                params = t_strsplit(*tmp, ":");
+               group_by.field = p_strdup(pool, params[0]);
 
                if (params[1] == NULL) {
                        /* <field name> - alias for <field>:discrete */
@@ -485,8 +486,6 @@ static bool parse_metric_group_by(struct stats_metric_settings *set,
                        return FALSE;
                }
 
-               group_by.field = p_strdup(pool, params[0]);
-
                array_push_back(&set->parsed_group_by, &group_by);
        }